Skip to main content
EQ
Foundry
Back to Guides
workflow · Engineers

Running a Design Review

How to use the Design Review workflow to catch accessibility and pattern issues before merge

Overview

The Design Review workflow automates UI quality checks that designers and frontend engineers otherwise do by hand. Two review agents: quality and patterns: scan your code and report findings with confidence scores.

When to Run

Run a design review when your PR touches:

  • Component libraries or shared UI components
  • Layout, spacing, or typography changes
  • Accessibility-sensitive elements (forms, modals, navigation)
  • Design system tokens or theme values

How It Works

1. Install the workflow

npx skills add mclaude95/eq-foundry -s eq-review-quality -s eq-review-patterns

2. Run the review

From your feature branch:

/eq-review-quality

This scans for accessibility violations, test quality gaps, performance patterns, and defensive data handling. Findings below 70% confidence are excluded.

3. Check patterns separately

/eq-review-patterns

This checks design system conventions, prop field coverage, and route segment file coverage. The convention scanner runs first (fast, deterministic), then the LLM-based review follows.

4. Add Storybook coverage (optional)

If your component has interactive states:

/eq-storybook-test src/components/YourComponent.tsx

This determines whether a story is needed and what belongs in play() vs .test.tsx.

What Gets Checked

AreaWhat It Catches
AccessibilityMissing ARIA labels, insufficient contrast, keyboard traps
Test qualityShallow assertions, missing edge cases, untested states
PerformanceUnnecessary re-renders, large bundle imports, missing lazy loading
Pattern complianceDesign system drift, inconsistent spacing, prop mismatches
Visual regressionInteractive state coverage via Storybook play functions

Tips

  • Run quality and patterns separately for faster feedback during development
  • Use the full /eq-review for a combined pass before opening a PR
  • Both skills flag issues but never auto-fix